Albert Astals Cid
93336bb110
Enable more clang-tidy modernize checks
2020-01-30 18:02:17 +01:00
Albert Astals Cid
8ee19a09e2
Add a few modernize clang-tidy checks
2020-01-30 17:37:15 +01:00
Albert Astals Cid
0398e228de
Add clang-tidy to the clazy CI
2020-01-30 16:55:33 +01:00
Albert Astals Cid
a177dbaae4
Remove QPROC_SIGNAL_RELAY define
...
It was always defined anyway, so makes the code easier to understand
2020-01-30 16:29:56 +01:00
Albert Astals Cid
4c31e0c81f
static -> static const
2020-01-30 13:52:21 +01:00
Albert Astals Cid
c5f5a4c038
clazy: Enable level2 except a few checks
...
also a few of the manual checks
2020-01-29 17:36:23 +01:00
Albert Astals Cid
294cf98f59
Enable all clazy level 0 tests except one
...
one: containter-anti-pattern, needs some bigger rework
2020-01-29 15:16:08 +01:00
Albert Astals Cid
dce16514fe
Enable a clazy CI
...
Starting with only missing-qobject-macro check enabled
2020-01-29 14:31:55 +01:00
Albert Astals Cid
7df8f7e215
Move to the new connect syntax
...
QProcess::errorOccurred is since 5.6 so increase min version
2020-01-29 08:34:13 +00:00
Albert Astals Cid
f9fc3f356f
remove unused variables
2020-01-24 10:46:27 +01:00
Albert Astals Cid
d298a11af7
SASL_AUTH_EXTERNAL wants a char * not a char **
...
Reviewers: sitter
Reviewed By: sitter
Differential Revision: https://phabricator.kde.org/D26879
2020-01-23 23:33:03 +01:00
Albert Astals Cid
d3fd2d9a10
Don't store the char * of a bytearray.toLatin1().data()
...
It's dangling memory
2020-01-23 17:45:05 +01:00
Albert Astals Cid
d3f8ea684e
QString::mid -> midRef
2020-01-23 17:40:59 +01:00
Albert Astals Cid
6a1d268315
Enable QT_NO_CAST_FROM_BYTEARRAY
2020-01-23 17:26:29 +01:00
Albert Astals Cid
dbef5838d4
Enable QT_NO_SIGNALS_SLOTS_KEYWORDS
2020-01-22 19:31:28 +01:00
Albert Astals Cid
80f58d05f0
Fix BotanHKDFContext::clone
...
And excercise it in the unittest
2020-01-21 17:41:24 +01:00
Albert Astals Cid
4449dd088b
Fix KDFContex clone in botan/gcrypt
...
And excercise that from the unittest
2020-01-21 01:19:50 +01:00
Albert Astals Cid
29c7d98898
Fix MACContext clone in botan/gcrypt/nss
...
And excercise that from the unittest
2020-01-21 01:12:07 +01:00
Albert Astals Cid
0ce2b3927e
Fix HashContext in botan/gcrypt/nss
...
And make sure the hashunittest exercises them
2020-01-21 00:54:10 +01:00
Albert Astals Cid
501a539c22
botan: Require botan2
...
It's already 2 years old, more than sensible to ask for uptodate crypto
stuff
2020-01-20 23:32:04 +01:00
Albert Astals Cid
c0d8f1807d
botan: remove stdout here
...
This gets called on initialization and most people won't even probably
will be asking for this particular method so no need to be annoying
2020-01-20 23:04:36 +01:00
Albert Astals Cid
c1a4ad1ab1
botan: check md2 is supported before saying it is
2020-01-20 23:03:28 +01:00
Albert Astals Cid
61daaffee6
openssl: Reenable whirpool
...
If that means ancient openssl don't work, that's the problem of people
using ancient openssl
2020-01-20 22:49:09 +01:00
Albert Astals Cid
391360f145
gcrypt: disable des, seems it fails on some cases
2020-01-20 20:02:02 +01:00
Albert Astals Cid
f429960d58
qcrypt: Fix crash on platforms where uint and size_t are different
2020-01-20 20:02:02 +01:00
Albert Astals Cid
a77ea02b8d
botan: Check if ciphers are supported before saying they are
...
Now all tests pass :)
2020-01-20 20:02:02 +01:00
Laurent Montel
acb45eeb84
Use nullptr
2020-01-20 13:37:51 +01:00
Albert Astals Cid
5105fc4981
botan: Make sure it supports pbkdf1(md2) before saying we to
...
At least my version (2.13.0) doesn't seem to support it
"Fixes" kdfunittest
2020-01-20 00:46:41 +01:00
Albert Astals Cid
b9d80939c6
botan: Fix crash if asking for something botan doesn't provide
...
Fixes crash in KDFUnitTest with my botan installation
2020-01-19 22:32:32 +01:00
Albert Astals Cid
1b061d63a8
gpg: use the loopback pinentry
...
otherwise we don't get asked back for passphrase like we want to
2020-01-19 22:17:53 +01:00
Albert Astals Cid
a0194d7ffd
qFind -> std::find
2020-01-19 18:01:15 +01:00
Albert Astals Cid
70406170f5
Cleanup Qt version checks
2020-01-19 17:57:35 +01:00
Albert Astals Cid
4ad7e911d9
QString::sprintf -> QString::asprintf
2020-01-19 17:45:25 +01:00
Albert Astals Cid
83c23c7a3a
QTime -> QElapsedTimer
2020-01-19 17:32:15 +01:00
Albert Astals Cid
d71f4c279b
Drop Qt4 support
2020-01-19 17:19:23 +01:00
Albert Astals Cid
00d311d90f
Add override
2020-01-19 16:28:44 +01:00
Albert Astals Cid
326399794e
qca-botan: Don't crash if BotanCipherContext fails
...
Makes the cipher unit test at least not crash (even if it doesn't pass)
2020-01-19 16:27:09 +01:00
Hannah von Reth
1137ed5f07
Require CMake 3.4 and use the OpenSSL imported libs
...
Summary:
Fixes
00:09:45.140 [162/278] Linking CXX shared module lib/qca-qt5/crypto/libqca-ossl.dylib
00:09:45.140 FAILED: lib/qca-qt5/crypto/libqca-ossl.dylib
00:09:45.140 : && /usr/bin/clang++ -O2 -g -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -bundle -Wl,-headerpad_max_install_names -o lib/qca-qt5/crypto/libqca-ossl.dylib plugins/qca-ossl/CMakeFiles/qca-ossl.dir/qca-ossl.cpp.o lib/qca-qt5.framework/Versions/2.2.0/qca-qt5 /Users/packaging/Craft/BinaryCache/macos-64-clang/lib/libssl.dylib /Users/packaging/Craft/BinaryCache/macos-64-clang/lib/libcrypto.dylib -lcrypto /Users/packaging/Craft/BinaryCache/macos-64-clang/lib/QtCore.framework/QtCore -framework CoreFoundation -framework Security && :
00:09:45.140 ld: library not found for -lcrypto
00:09:45.140 clang: error: linker command failed with exit code 1 (use -v to see invocation)
Reviewers: dfaure, bcooksley, volkov
Reviewed By: dfaure
Differential Revision: https://phabricator.kde.org/D17913
2019-03-04 12:16:36 +01:00
Alexander Volkov
32343842d3
Fix build with botan < 2 and openssl < 1.1
...
Summary:
This commit amends f57d661416ecbdfbf9c16d8116c296cfdcbeb7d6.
HKDF support was added only in the new versions of the libs.
Reviewers: dfaure, bcooksley
Reviewed By: dfaure
Differential Revision: https://phabricator.kde.org/D16248
2018-10-17 14:54:34 +03:00
Alexander Volkov
f57d661416
Introduce HKDF
...
Summary:
It's needed for implementation of Secret Service:
https://specifications.freedesktop.org/secret-service/ch07s03.html
Reviewers: iromanov, sitter, #frameworks, dfaure
Reviewed By: dfaure
Subscribers: dfaure
Differential Revision: https://phabricator.kde.org/D15510
2018-10-15 14:30:05 +03:00
Harald Sitter
da4d1d06d4
Openssl fix deprecation warnings
...
Summary:
Openssl fix deprecation warnings
Removed unused function: X509_SIG_getm
deprecated warnings for:
ASN1_STRING_data
DSA_generate_parameters
RSA_generate_key
RAND_pseudo_bytes
Tested with openssl-1.0.2l on ubuntu:14.04
Deprecation warning spotted with openssl-1.1.0.g-1
one deprecation warning left: TLSv1_client_method
Reviewers: sitter, fvogt
Reviewed By: fvogt
Differential Revision: https://phabricator.kde.org/D11616
2018-06-19 11:46:09 +02:00
Antonio Rojas
78503bf574
Recommit botan 2 support without making botan mandatory
...
Differential Revision: https://phabricator.kde.org/D11997
2018-04-12 10:03:12 +02:00
Ben Cooksley
01cbb31770
Revert "Add botan 2 support"
...
This change adds a mandatory dependency on Botan, which is not available at this time within Craft.
As this change was not notified to Sysadmin and because it has left us in a state whereby we are unable to get the Windows CI system back up and running, this is being reverted so it can be brought back online.
Please reintroduce this change once support for having Botan as optional is restored
This reverts commit 47163784d74232e3a844fc42897bffc7eff817b4.
2018-04-12 19:48:32 +12:00
Antonio Rojas
47163784d7
Add botan 2 support
...
Botan 1.10 will be EOL'd this year. This patch is a rough port to botan 2 API. Also:
- Removes support for botan < 1.10 to simplify code (1.10 was released 7 years ago)
- Ports the cmake module to use pkgconfig, since botan-config doesn't exist anymore in v2.
- To minimize ifdef'd code, botan2 unique_ptr's are release'd
- Removes -ansi C(XX)FLAGS, botan 2 requires C++11
Differential Revision: https://phabricator.kde.org/D11997
2018-04-11 21:43:57 +02:00
Fabian Vogt
d58e20ee65
Add support for OpenSSL 1.1.0
...
Test Plan:
Ran the testsuite with OpenSSL 1.1.0g and 1.0.2j, all passed.
Using this code with kdeconnect and okteta successfully on my system now.
Reviewers: iromanov
Subscribers: anthonyfieroni, alonbl, heikobecker, cfeck, asturmlechner, bero, rdieter
Differential Revision: https://phabricator.kde.org/D9416
2018-01-04 20:02:38 +01:00
Ivan Romanov
d320ef4fdb
Add some missed headers to Qt Creator project
2016-10-10 21:50:18 +05:00
Ivan Romanov
57878ff44f
Add support for AES GCM and AES CCM modes
...
Only qca-openssl now can use GCM and CCM. CCM is not tested and
planed for future.
2016-09-19 10:48:11 +05:00
Raphael Kubo da Costa
84f53aea25
qca-ossl: Remove SHA0 from all_hash_types() when it is not available.
...
Commit 0dbed8e ("qca-ossl: Fix build without support for SHA-0") forgot
to add an #ifdef check for SHA0 support in all_hash_types().
REVIEW: 128700
2016-08-18 08:52:57 +02:00
Ivan Romanov
558f819819
gnupg: use utf-8 for keys output
2015-10-29 10:52:11 +05:00
Ivan Romanov
bf61f35cb4
gnupg: fixed keys is not updating
...
On Windows gpg uses ANSI codepage to output homedir and keyrings
paths. No way to output in utf-8. Gpg returns utf-8 strings output
only when --with-colons option is used.
2015-10-29 10:52:11 +05:00