Test Plan: Same tests as before pass
Reviewers: iromanov, sitter, dfaure, #frameworks
Reviewed By: sitter
Differential Revision: https://phabricator.kde.org/D25802
Summary:
This reverts the QcaMacro changes of
commit 1137ed5f07d137296874f7dd1ee629f903507161 as they seem fairly
unrelated to the actual openssl change and proof to cause persistent issues
with buildability.
Further revert "unbreak build by moving away from deprecated exec_program"
This reverts commit 32419c899c77b8f5ece374d2453ee37e89af7c10.
Which was done in an attempt to remidy the build problems.
Further revert "Actually abort after the message that tells people to set CMAKE_INSTALL_PREFIX"
This reverts commit 63fd27fbce780bccb9c9b3ff6649888cfd809c6a.
Which was also done in an attempt to fix the problems.
BUG: 406353
Test Plan:
- when configuring without any arguments the qmake derived paths are used and correct
- when configuring with CMAKE_INSTALL_PREFIX the paths are accordingly reported below that
QCA prefix is /opt
Plugins will be installed to /opt/lib/qca-qt5
Binary will be installed to /opt/bin
Library will be installed to /opt/lib
Public headers will be installed to /opt/include/Qca-qt5
Private headers will be installed to /opt/include/Qca-qt5
Feature file will be installed to /opt/mkspecs/features
Documentation will be installed to /opt/share/doc/qca-qt5/html
Man page will be installed to /opt/share/man
Pkg-config file will be installed to /opt/lib/pkgconfig
Reviewers: dfaure, arojas, vonreth
Reviewed By: dfaure, arojas
Differential Revision: https://phabricator.kde.org/D20408
Summary:
since 1137ed5f07d137296874f7dd1ee629f903507161 which bumped cmake and
started using TARGET_FILE for the qmake calls qca failed to build for me.
I fail to understand why exactly that is but I suspect it has to do with
the fact that exec_program is deprecated and may not be working
(correctly?) with generator expressions.
moving to the not deprecated execute_process fixes clean builds on my
system and is at the very least a move away from deprecated tech with
no downsides
Test Plan: rm -rf * && cmake -DCMAKE_INSTALL_PREFIX=/usr ..
Reviewers: asturmlechner, dfaure, vonreth
Reviewed By: dfaure
Differential Revision: https://phabricator.kde.org/D20228
Test Plan:
`mkdir build ; cd build ; cmake ..` no longer prints out weird stuff after
the "!!!!" error message, it actually stops there as intended (AFAICS).
Summary:
This commit amends f57d661416ecbdfbf9c16d8116c296cfdcbeb7d6.
HKDF support was added only in the new versions of the libs.
Reviewers: dfaure, bcooksley
Reviewed By: dfaure
Differential Revision: https://phabricator.kde.org/D16248
Summary: I did not find it in use somewhere else.
Reviewers: iromanov, sitter, rjvbb
Reviewed By: rjvbb
Subscribers: fvogt
Differential Revision: https://phabricator.kde.org/D12129
This change adds a mandatory dependency on Botan, which is not available at this time within Craft.
As this change was not notified to Sysadmin and because it has left us in a state whereby we are unable to get the Windows CI system back up and running, this is being reverted so it can be brought back online.
Please reintroduce this change once support for having Botan as optional is restored
This reverts commit 47163784d74232e3a844fc42897bffc7eff817b4.
Botan 1.10 will be EOL'd this year. This patch is a rough port to botan 2 API. Also:
- Removes support for botan < 1.10 to simplify code (1.10 was released 7 years ago)
- Ports the cmake module to use pkgconfig, since botan-config doesn't exist anymore in v2.
- To minimize ifdef'd code, botan2 unique_ptr's are release'd
- Removes -ansi C(XX)FLAGS, botan 2 requires C++11
Differential Revision: https://phabricator.kde.org/D11997
Test Plan:
Ran the testsuite with OpenSSL 1.1.0g and 1.0.2j, all passed.
Using this code with kdeconnect and okteta successfully on my system now.
Reviewers: iromanov
Subscribers: anthonyfieroni, alonbl, heikobecker, cfeck, asturmlechner, bero, rdieter
Differential Revision: https://phabricator.kde.org/D9416
Revert "Add missed file"
This reverts commit 4c9f27270e0a7c00c10cbc56ce5c6842b47e5ab2.
FindCoreFoundation.cmake is not needed since CoreFoundation
is a system framework. Its use has been removed by
commit f223ce03d4b94ffbb093fc8be5adf8d968f54434
Acked by: Ivan Čukić
REVIEW: 126285
