QuasarApp/qca
4
0
Fork 0
mirror of https://github.com/QuasarApp/qca.git synced 2025-05-17 04:49:32 +00:00
Code Issues Projects Releases Wiki Activity

Don't store the char * of a bytearray.toLatin1().data()

Browse Source 
It's dangling memory
This commit is contained in:
Albert Astals Cid 2020-01-23 17:44:42 +01:00
parent d3f8ea684e
commit d3fd2d9a10
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/qca-cyrus-sasl/qca-cyrus-sasl.cpp
View File

@ -309,7 +309,8 @@ private:
return false; return false;
if(!ext_authid.isEmpty()) { if(!ext_authid.isEmpty()) {
const char *authid = ext_authid.toLatin1().data(); const QByteArray ext_authidBA = ext_authid.toLatin1();
const char *authid = ext_authidBA.data();
sasl_ssf_t ssf = ext_ssf; sasl_ssf_t ssf = ext_ssf;
r = sasl_setprop(con, SASL_SSF_EXTERNAL, &ssf); r = sasl_setprop(con, SASL_SSF_EXTERNAL, &ssf);
if(r != SASL_OK) if(r != SASL_OK)