QuasarApp/qca
4
0
Fork 0
mirror of https://github.com/QuasarApp/qca.git synced 2025-04-28 12:34:31 +00:00
Code Issues Projects Releases Wiki Activity

take out unclear bool args

Browse Source 
svn path=/trunk/kdesupport/qca/; revision=393732
This commit is contained in:
Justin Karneges 2005-02-28 07:31:19 +00:00
parent 466fcf3673
commit c3bbe0b6ec
3 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
TODO
View File

@ -14,17 +14,14 @@
think about documenting the various providers (qcaprovider.h)
* Considerations
threading (safety, usability) in API and plugins. look for singletons
it's possible we use QSecureArray in some unnecessary places
don't forget to QCA_EXPORT everything
standardize on count() vs size() when iterating?
* finish API:
do something about qhostaddress in SASL. try to remove QtNetwork dependency?
move to qt 4
use qshareddata for thread-safe objects
turn ambiguous bool args into enums
create include files for all class names?
algorithm: qshareddata?
qcaprovider.h
* build system:
get qt 4 support into qconf
@ -33,6 +30,8 @@
create qt4 qmake .prf for auto-discovery by applications
* finish code for APIs:
deal with thread issues at central points:
secure memory, qca_plugin, keygen, securemessagesystem
cipher - needs to handling padding
mac
pkey

22
include/QtCrypto/qca_securelayer.h
View File

@ -210,6 +210,22 @@ namespace QCA
RequireMutualAuth = 0x10,
RequireAuthzidSupport = 0x20 // server-only
};
enum ClientSendMode
{
AllowClientSendFirst,
DisableClientSendFirst
};
enum ServerSendMode
{
AllowServerSendLast,
DisableServerSendLast
};
class Params
{
public:
bool user, authzid, pass, realm;
};
SASL(QObject *parent = 0, const QString &provider = QString());
~SASL();
@ -225,8 +241,8 @@ namespace QCA
void setExternalSSF(int);
// main
bool startClient(const QString &service, const QString &host, const QStringList &mechlist, bool allowClientSendFirst = true);
bool startServer(const QString &service, const QString &host, const QString &realm, QStringList *mechlist, bool allowServerSendLast = false);
bool startClient(const QString &service, const QString &host, const QStringList &mechlist, ClientSendMode = AllowClientSendFirst);
bool startServer(const QString &service, const QString &host, const QString &realm, QStringList *mechlist, ServerSendMode = DisableServerSendLast);
void putStep(const QByteArray &stepData);
void putServerFirstStep(const QString &mech);
void putServerFirstStep(const QString &mech, const QByteArray &clientInit);
@ -255,7 +271,7 @@ namespace QCA
signals:
void clientFirstStep(const QString &mech, const QByteArray *clientInit);
void nextStep(const QByteArray &stepData);
void needParams(bool user, bool authzid, bool pass, bool realm);
void needParams(const Params &params);
void authCheck(const QString &user, const QString &authzid);
void authenticated();

8
src/qca_securelayer.cpp
View File

@ -475,7 +475,7 @@ void SASL::setRemoteAddr(const QHostAddress &addr, Q_UINT16 port)
d->remotePort = port;
}*/
bool SASL::startClient(const QString &service, const QString &host, const QStringList &mechlist, bool allowClientSendFirst)
bool SASL::startClient(const QString &service, const QString &host, const QStringList &mechlist, ClientSendMode)
{
SASLContext::HostPort la, ra;
/*if(d->localPort != -1) {
@ -487,7 +487,7 @@ bool SASL::startClient(const QString &service, const QString &host, const QStrin
ra.port = d->remotePort;
}*/
d->allowCSF = allowClientSendFirst;
//d->allowCSF = allowClientSendFirst;
d->c->setCoreProps(service, host, d->localPort != -1 ? &la : 0, d->remotePort != -1 ? &ra : 0);
d->setSecurityProps();
@ -500,9 +500,9 @@ bool SASL::startClient(const QString &service, const QString &host, const QStrin
return true;
}
bool SASL::startServer(const QString &service, const QString &host, const QString &realm, QStringList *mechlist, bool allowServerSendLast)
bool SASL::startServer(const QString &service, const QString &host, const QString &realm, QStringList *mechlist, ServerSendMode)
{
Q_UNUSED(allowServerSendLast);
//Q_UNUSED(allowServerSendLast);
SASLContext::HostPort la, ra;
/*if(d->localPort != -1) {