mirror of
https://github.com/QuasarApp/openssl.git
synced 2025-05-11 00:49:41 +00:00
3e5f19a352
There are two undocumented DSA parameter generation options available in
the genpkey command line app:
dsa_paramgen_md and dsa_paramgen_q_bits.
These can also be accessed via the EVP API but only by using
EVP_PKEY_CTX_ctrl() or EVP_PKEY_CTX_ctrl_str() directly. There are no
helper macros for these options.
dsa_paramgen_q_bits sets the length of q in bits (default 160 bits).
dsa_paramgen_md sets the digest that is used during the parameter
generation (default SHA1). In particular the output length of the digest
used must be equal to or greater than the number of bits in q because of
this code:
if (!EVP_Digest(seed, qsize, md, NULL, evpmd, NULL))
goto err;
if (!EVP_Digest(buf, qsize, buf2, NULL, evpmd, NULL))
goto err;
for (i = 0; i < qsize; i++)
md[i] ^= buf2[i];
/* step 3 */
md[0] |= 0x80;
md[qsize - 1] |= 0x01;
if (!BN_bin2bn(md, qsize, q))
goto err;
qsize here is the number of bits in q and evpmd is the digest set via
dsa_paramgen_md. md and buf2 are buffers of length SHA256_DIGEST_LENGTH.
buf2 has been filled with qsize bits of random seed data, and md is
uninitialised.
If the output size of evpmd is less than qsize then the line "md[i] ^=
buf2[i]" will be xoring an uninitialised value and the random seed data
together to form the least significant bits of q (and not using the
output of the digest at all for those bits) - which is probably not what
was intended. The same seed is then used as an input to generating p. If
the uninitialised data is actually all zeros (as seems quite likely)
then the least significant bits of q will exactly match the least
significant bits of the seed.
This problem only occurs if you use these undocumented and difficult to
find options and you set the size of q to be greater than the message
digest output size. This is for parameter generation only not key
generation. This scenario is considered highly unlikely and
therefore the security risk of this is considered negligible.
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5884)
135 lines
5.7 KiB
C
135 lines
5.7 KiB
C
/* crypto/dsa/dsa_err.c */
|
|
/* ====================================================================
|
|
* Copyright (c) 1999-2018 The OpenSSL Project. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
*
|
|
* 3. All advertising materials mentioning features or use of this
|
|
* software must display the following acknowledgment:
|
|
* "This product includes software developed by the OpenSSL Project
|
|
* for use in the OpenSSL Toolkit. (http://www.OpenSSL.org/)"
|
|
*
|
|
* 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to
|
|
* endorse or promote products derived from this software without
|
|
* prior written permission. For written permission, please contact
|
|
* openssl-core@OpenSSL.org.
|
|
*
|
|
* 5. Products derived from this software may not be called "OpenSSL"
|
|
* nor may "OpenSSL" appear in their names without prior written
|
|
* permission of the OpenSSL Project.
|
|
*
|
|
* 6. Redistributions of any form whatsoever must retain the following
|
|
* acknowledgment:
|
|
* "This product includes software developed by the OpenSSL Project
|
|
* for use in the OpenSSL Toolkit (http://www.OpenSSL.org/)"
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY
|
|
* EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
|
|
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE OpenSSL PROJECT OR
|
|
* ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
|
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
|
|
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
|
|
* OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
* ====================================================================
|
|
*
|
|
* This product includes cryptographic software written by Eric Young
|
|
* (eay@cryptsoft.com). This product includes software written by Tim
|
|
* Hudson (tjh@cryptsoft.com).
|
|
*
|
|
*/
|
|
|
|
/*
|
|
* NOTE: this file was auto generated by the mkerr.pl script: any changes
|
|
* made to it will be overwritten when the script next updates this file,
|
|
* only reason strings will be preserved.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <openssl/err.h>
|
|
#include <openssl/dsa.h>
|
|
|
|
/* BEGIN ERROR CODES */
|
|
#ifndef OPENSSL_NO_ERR
|
|
|
|
# define ERR_FUNC(func) ERR_PACK(ERR_LIB_DSA,func,0)
|
|
# define ERR_REASON(reason) ERR_PACK(ERR_LIB_DSA,0,reason)
|
|
|
|
static ERR_STRING_DATA DSA_str_functs[] = {
|
|
{ERR_FUNC(DSA_F_D2I_DSA_SIG), "d2i_DSA_SIG"},
|
|
{ERR_FUNC(DSA_F_DO_DSA_PRINT), "DO_DSA_PRINT"},
|
|
{ERR_FUNC(DSA_F_DSAPARAMS_PRINT), "DSAparams_print"},
|
|
{ERR_FUNC(DSA_F_DSAPARAMS_PRINT_FP), "DSAparams_print_fp"},
|
|
{ERR_FUNC(DSA_F_DSA_BUILTIN_PARAMGEN2), "DSA_BUILTIN_PARAMGEN2"},
|
|
{ERR_FUNC(DSA_F_DSA_DO_SIGN), "DSA_do_sign"},
|
|
{ERR_FUNC(DSA_F_DSA_DO_VERIFY), "DSA_do_verify"},
|
|
{ERR_FUNC(DSA_F_DSA_GENERATE_KEY), "DSA_generate_key"},
|
|
{ERR_FUNC(DSA_F_DSA_GENERATE_PARAMETERS_EX),
|
|
"DSA_generate_parameters_ex"},
|
|
{ERR_FUNC(DSA_F_DSA_NEW_METHOD), "DSA_new_method"},
|
|
{ERR_FUNC(DSA_F_DSA_PARAM_DECODE), "DSA_PARAM_DECODE"},
|
|
{ERR_FUNC(DSA_F_DSA_PRINT_FP), "DSA_print_fp"},
|
|
{ERR_FUNC(DSA_F_DSA_PRIV_DECODE), "DSA_PRIV_DECODE"},
|
|
{ERR_FUNC(DSA_F_DSA_PRIV_ENCODE), "DSA_PRIV_ENCODE"},
|
|
{ERR_FUNC(DSA_F_DSA_PUB_DECODE), "DSA_PUB_DECODE"},
|
|
{ERR_FUNC(DSA_F_DSA_PUB_ENCODE), "DSA_PUB_ENCODE"},
|
|
{ERR_FUNC(DSA_F_DSA_SIGN), "DSA_sign"},
|
|
{ERR_FUNC(DSA_F_DSA_SIGN_SETUP), "DSA_sign_setup"},
|
|
{ERR_FUNC(DSA_F_DSA_SIG_NEW), "DSA_SIG_new"},
|
|
{ERR_FUNC(DSA_F_DSA_SIG_PRINT), "DSA_SIG_PRINT"},
|
|
{ERR_FUNC(DSA_F_DSA_VERIFY), "DSA_verify"},
|
|
{ERR_FUNC(DSA_F_I2D_DSA_SIG), "i2d_DSA_SIG"},
|
|
{ERR_FUNC(DSA_F_OLD_DSA_PRIV_DECODE), "OLD_DSA_PRIV_DECODE"},
|
|
{ERR_FUNC(DSA_F_PKEY_DSA_CTRL), "PKEY_DSA_CTRL"},
|
|
{ERR_FUNC(DSA_F_PKEY_DSA_CTRL_STR), "PKEY_DSA_CTRL_STR"},
|
|
{ERR_FUNC(DSA_F_PKEY_DSA_KEYGEN), "PKEY_DSA_KEYGEN"},
|
|
{ERR_FUNC(DSA_F_SIG_CB), "SIG_CB"},
|
|
{0, NULL}
|
|
};
|
|
|
|
static ERR_STRING_DATA DSA_str_reasons[] = {
|
|
{ERR_REASON(DSA_R_BAD_Q_VALUE), "bad q value"},
|
|
{ERR_REASON(DSA_R_BN_DECODE_ERROR), "bn decode error"},
|
|
{ERR_REASON(DSA_R_BN_ERROR), "bn error"},
|
|
{ERR_REASON(DSA_R_DATA_TOO_LARGE_FOR_KEY_SIZE),
|
|
"data too large for key size"},
|
|
{ERR_REASON(DSA_R_DECODE_ERROR), "decode error"},
|
|
{ERR_REASON(DSA_R_INVALID_DIGEST_TYPE), "invalid digest type"},
|
|
{ERR_REASON(DSA_R_INVALID_PARAMETERS), "invalid parameters"},
|
|
{ERR_REASON(DSA_R_MISSING_PARAMETERS), "missing parameters"},
|
|
{ERR_REASON(DSA_R_MODULUS_TOO_LARGE), "modulus too large"},
|
|
{ERR_REASON(DSA_R_NEED_NEW_SETUP_VALUES), "need new setup values"},
|
|
{ERR_REASON(DSA_R_NON_FIPS_DSA_METHOD), "non fips dsa method"},
|
|
{ERR_REASON(DSA_R_NO_PARAMETERS_SET), "no parameters set"},
|
|
{ERR_REASON(DSA_R_PARAMETER_ENCODING_ERROR), "parameter encoding error"},
|
|
{ERR_REASON(DSA_R_Q_NOT_PRIME), "q not prime"},
|
|
{0, NULL}
|
|
};
|
|
|
|
#endif
|
|
|
|
void ERR_load_DSA_strings(void)
|
|
{
|
|
#ifndef OPENSSL_NO_ERR
|
|
|
|
if (ERR_func_error_string(DSA_str_functs[0].error) == NULL) {
|
|
ERR_load_strings(0, DSA_str_functs);
|
|
ERR_load_strings(0, DSA_str_reasons);
|
|
}
|
|
#endif
|
|
}
|