Matt Caswell 7cccecc0b6 Don't attempt to duplicate the BIO state in SSL_dup
SSL_dup attempted to duplicate the BIO state if the source SSL had BIOs
configured for it. This did not work.

Firstly the SSL_dup code was passing a BIO ** as the destination
argument for BIO_dup_state. However BIO_dup_state expects a BIO * for that
parameter. Any attempt to use this will either (1) fail silently, (2) crash
or fail in some other strange way.

Secondly many BIOs do not implement the BIO_CTRL_DUP ctrl required to make
this work.

Thirdly, if rbio == wbio in the original SSL object, then an attempt is made
to up-ref the BIO in the new SSL object - even though it hasn't been set
yet and is NULL. This results in a crash.

This appears to have been broken for a very long time with at least some of
the problems described above coming from SSLeay. The simplest approach is
to just remove this capability from the function.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/12180)
2020-06-23 12:46:47 +01:00
..
2019-07-02 14:22:29 +02:00
2020-06-04 14:33:57 +01:00
2020-06-04 14:33:57 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2019-12-11 19:04:01 +01:00
2020-04-23 13:55:52 +01:00
2019-10-11 15:30:57 +02:00
2020-04-23 13:55:52 +01:00
2019-10-11 15:30:57 +02:00
2019-10-11 15:30:57 +02:00
2020-04-23 13:55:52 +01:00
2019-10-31 14:26:34 +01:00
2019-08-19 00:06:41 +02:00
2020-04-23 13:55:52 +01:00
2019-10-14 22:54:02 +02:00
2019-08-19 07:19:56 +02:00
2019-07-01 10:09:22 +02:00
2020-06-16 16:15:37 +02:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-05-18 09:34:07 +01:00
2020-05-15 14:09:49 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-06-04 14:33:57 +01:00
2020-06-04 14:33:57 +01:00
2020-04-23 13:55:52 +01:00
2019-12-11 19:04:01 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2019-11-15 17:20:33 +01:00
2019-11-15 17:20:33 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2019-07-02 14:22:29 +02:00
2019-09-04 10:38:13 +02:00
2020-06-04 14:33:57 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2019-12-11 19:04:01 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-06-18 10:10:48 +03:00
2020-04-23 13:55:52 +01:00
2020-05-15 14:09:49 +01:00
2019-10-09 17:44:04 +02:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2019-10-31 14:26:34 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-03-09 10:46:57 +01:00
2020-05-15 14:09:49 +01:00
2020-04-23 13:55:52 +01:00
2019-12-11 19:04:01 +01:00
2020-06-04 14:33:57 +01:00
2020-06-04 14:33:57 +01:00
2019-08-19 00:06:41 +02:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-28 09:06:04 +10:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2020-06-04 14:33:57 +01:00
2020-04-23 13:55:52 +01:00
2020-04-23 13:55:52 +01:00
2019-05-31 12:23:58 +02:00
2020-04-23 13:55:52 +01:00