QuasarApp/openssl
4
0
Fork 0
mirror of https://github.com/QuasarApp/openssl.git synced 2025-04-29 19:24:37 +00:00
Code Issues Projects Releases Wiki Activity

VMS getnameinfo() seems to have a bug with returned service string

Browse Source 
It seems like it gives back gibberish.  If we asked for a numeric
service, it's easy to check for a digit in the first position, and
if there isn't any, rewrite it using older methods.

Reviewed-by: Rich Salz <rsalz@openssl.org>
This commit is contained in:
Richard Levitte 2016-02-10 05:12:52 +01:00
parent e8461ee1d1
commit d40cf9bc9c
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
crypto/bio/b_addr.c
View File

@ -58,6 +58,7 @@
#include <openssl/err.h>
#include <openssl/buffer.h>
#include <ctype.h>
/*
* Throughout this file and bio_lcl.h, the existence of the macro
@ -250,6 +251,16 @@ static int addr_strings(const BIO_ADDR *ap, int numeric,
}
return 0;
}
/* VMS getnameinfo() seems to have a bug, where serv gets filled
* with gibberish. We can at least check for digits when flags
* has NI_NUMERICSERV enabled
*/
if ((flags & NI_NUMERICSERV) != 0 && !isdigit(serv[0])) {
BIO_snprintf(serv, sizeof(serv), "%d",
ntohs(BIO_ADDR_rawport(ap)));
}
if (hostname)
*hostname = OPENSSL_strdup(host);
if (service)