QuasarApp/openssl
4
0
Fork 0
mirror of https://github.com/QuasarApp/openssl.git synced 2025-04-29 03:04:37 +00:00
Code Issues Projects Releases Wiki Activity

Remove unnecessary BIO_do_handshake()s

Browse Source 
Since BIO_do_connect() and BIO_do_handshake() are same, no
need to invoke BIO_do_handshake() once more after BIO_do_connect().

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14725)
This commit is contained in:
Nan Xiao 2021-03-29 17:24:01 +08:00 committed by Tomas Mraz
parent 78043fe898
commit 975e37cd01
3 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
demos/bio/client-arg.c
View File

@ -94,12 +94,6 @@ int main(int argc, char **argv)
goto end; goto end;
} }
if (BIO_do_handshake(sbio) <= 0) {
fprintf(stderr, "Error establishing SSL connection\n");
ERR_print_errors_fp(stderr);
goto end;
}
/* Could examine ssl here to get connection info */ /* Could examine ssl here to get connection info */
BIO_puts(sbio, "GET / HTTP/1.0\n\n"); BIO_puts(sbio, "GET / HTTP/1.0\n\n");

6
demos/bio/client-conf.c
View File

@ -102,12 +102,6 @@ int main(int argc, char **argv)
goto end; goto end;
} }
if (BIO_do_handshake(sbio) <= 0) {
fprintf(stderr, "Error establishing SSL connection\n");
ERR_print_errors_fp(stderr);
goto end;
}
/* Could examine ssl here to get connection info */ /* Could examine ssl here to get connection info */
BIO_puts(sbio, "GET / HTTP/1.0\n\n"); BIO_puts(sbio, "GET / HTTP/1.0\n\n");

5
doc/man3/BIO_f_ssl.pod
View File

@ -188,11 +188,6 @@ unencrypted example in L<BIO_s_connect(3)>.
ERR_print_errors_fp(stderr); ERR_print_errors_fp(stderr);
exit(1); exit(1);
} }
if (BIO_do_handshake(sbio) <= 0) {
fprintf(stderr, "Error establishing SSL connection\n");
ERR_print_errors_fp(stderr);
exit(1);
}
/* XXX Could examine ssl here to get connection info */ /* XXX Could examine ssl here to get connection info */