Fix CID 1466712 : Resource leak in ec_kmgmt due to new callto ossl_prov_is_running()

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/12930)
This commit is contained in:
Shane Lontis 2020-09-21 11:29:30 +10:00
parent ad2dbfb543
commit 965d3f36c4

View File

@ -276,12 +276,16 @@ static int ec_match(const void *keydata1, const void *keydata2, int selection)
const EC_KEY *ec2 = keydata2;
const EC_GROUP *group_a = EC_KEY_get0_group(ec1);
const EC_GROUP *group_b = EC_KEY_get0_group(ec2);
BN_CTX *ctx = BN_CTX_new_ex(ec_key_get_libctx(ec1));
BN_CTX *ctx = NULL;
int ok = 1;
if (!ossl_prov_is_running())
return 0;
ctx = BN_CTX_new_ex(ec_key_get_libctx(ec1));
if (ctx == NULL)
return 0;
if ((selection & OSSL_KEYMGMT_SELECT_DOMAIN_PARAMETERS) != 0)
ok = ok && group_a != NULL && group_b != NULL
&& EC_GROUP_cmp(group_a, group_b, ctx) == 0;