QuasarApp/openssl
4
0
Fork 0
mirror of https://github.com/QuasarApp/openssl.git synced 2025-04-30 03:34:39 +00:00
Code Issues Projects Releases Wiki Activity

coverity 1462543 Logically dead code

Browse Source 
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/11651)
This commit is contained in:
Pauli 2020-04-27 08:05:23 +10:00
parent bd5f280091
commit 1f74259d42
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
crypto/cms/cms_kari.c
View File

@ -382,27 +382,27 @@ int cms_RecipientInfo_kari_init(CMS_RecipientInfo *ri, X509 *recip, EVP_PKEY *r
if (!cms_kari_create_ephemeral_key(kari, recipPubKey)) if (!cms_kari_create_ephemeral_key(kari, recipPubKey))
return 0; return 0;
} else { } else {
/* Use originator key */ /* Use originator key */
CMS_OriginatorIdentifierOrKey *oik = ri->d.kari->originator; CMS_OriginatorIdentifierOrKey *oik = ri->d.kari->originator;
if (originatorPrivKey == NULL && originator == NULL) if (originatorPrivKey == NULL || originator == NULL)
return 0; return 0;
if (flags & CMS_USE_ORIGINATOR_KEYID) { if (flags & CMS_USE_ORIGINATOR_KEYID) {
oik->type = CMS_OIK_KEYIDENTIFIER; oik->type = CMS_OIK_KEYIDENTIFIER;
oik->d.subjectKeyIdentifier = ASN1_OCTET_STRING_new(); oik->d.subjectKeyIdentifier = ASN1_OCTET_STRING_new();
if (oik->d.subjectKeyIdentifier == NULL) if (oik->d.subjectKeyIdentifier == NULL)
return 0; return 0;
if (!cms_set1_keyid(&oik->d.subjectKeyIdentifier, originator)) if (!cms_set1_keyid(&oik->d.subjectKeyIdentifier, originator))
return 0; return 0;
} else { } else {
oik->type = CMS_REK_ISSUER_SERIAL; oik->type = CMS_REK_ISSUER_SERIAL;
if (!cms_set1_ias(&oik->d.issuerAndSerialNumber, originator)) if (!cms_set1_ias(&oik->d.issuerAndSerialNumber, originator))
return 0; return 0;
} }
if (!cms_kari_set_originator_private_key(kari, originatorPrivKey)) if (!cms_kari_set_originator_private_key(kari, originatorPrivKey))
return 0; return 0;
} }
EVP_PKEY_up_ref(recipPubKey); EVP_PKEY_up_ref(recipPubKey);