Since we need the list anyway, we can move the is empty
check to the beginning of the function.
Change-Id: Iebe04b6f2904a02c807edaa7586af8a83c115c0a
Reviewed-on: http://codereview.qt.nokia.com/3414
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
It should be way faster to iterate over the known installed
packages list instead of all components to figure out if they
are installed.
Change-Id: I2fdb54c4063a3a886828129ad344c59216eb6509
Reviewed-on: http://codereview.qt.nokia.com/3173
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
Add a regular expression constant. Remove superfluous
check if the component is in the list, as in worst case
both methods need to iterate over the list to notice that
the component does not exist.
Review-By: Niels Weber
The proper fix for 308dc03e would have been to check if we
run in installer mode and only than check default components
initially. Not sure how a1a130b9 could state that the code
would work as expected, as proper testing would have revealed
that the "Next" button now was enabled always enabled in
package manager mode and always disabled in updater mode...
Fixes also the problem seen by Niels that in package manager
case components would have been scheduled for uninstall even
if we just selected a new component without removing an other.
Reviewed-By: Niels Weber
If we can't reach the given repo or if no repo is set, we
still need to support package managment to be able to
uninstall components found on the hard disk drive.
This makes it possible to use more then one instance
of the core engine per application. They now all listen
to the same port and use the same connection. Fixes a
memory leak as well as a crash during core engine destruct.
