To delete it's childs, the component uses qDeleteAll on the childs list,
but once a child get's deleted it removes itself from the calling
components child list and then messes up the list iterators. The child
list passed to qDeleteAll needs to be a deep copy of the list the
component owns to not mess with the original the calliing component holds.
Change-Id: I638ffbb576a9543b7197c8bf267239f31197e274
Reviewed-by: Karsten Heimrich <karsten.heimrich@nokia.com>
The message handler now forwards everything to the verbosew riter anyway.
Change-Id: I822f86e8f2e2e7690a3b855ed83199d2f41dc480
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
Save some QLatin1String - QString conversion, remove dead code.
Rename some functions, etc. Should not change much functionality.
Change-Id: I42bfbe19d773e9fa2cc18e11e74f71ef271f4130
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
- remove code that autodependency is a real dependency, it was a hack and totaly wrong
- introduce addDependency() to be able to add these operating system depend, for example you need vcredist to register Qt Simulator under Windows but not under the other OSs(the wrong autodependency was only a hack to allow this)
Change-Id: Iab6adc28d47b42eac1823afe7fe6a8bbfb2b3361
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
- with this we have the possiblity to set some variables or show a messagebox if that component is really installed, like to ask the user to stop a process
Change-Id: Ibe2044006835b301fd13e5ba226dc81ae6e25244
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
- with this new tag we are able to create simple components which have some content without a needed script
- this saves us some scriptengine instances in the future
Change-Id: Ib9890324bfbd9b18fb33f3f7bd88cae93c6a2062
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
This fixes several problems, e.g. once a component script has been
run, possible ui elements or even complete pages have been added.
On a second component script run these elements would have been
added again etc... Now we remove all pages and widget by default.
Change-Id: I47a3283ce06767c28529201432b71c0b4f12e533
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
Reviewed-by: Alexander Lenhardt <alexander.lenhardt@nokia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
- added support for version inheritance attributes to repogen
- added version inheritance for components
- 'inheritVersionFrom' attribute can be set for Version tags
added support for version inheritance attributes to repogen
Change-Id: I7e9a3a71620de2d8ffed0e0296b68f307304d9f6
Reviewed-by: Karsten Heimrich <karsten.heimrich@nokia.com>
Reviewed-by: Maurice Kalinowski <maurice.kalinowski@nokia.com>
- there was bug that unselected updates are removed in case there is an important update
- to avoid the error with old installation we are renaming Important tag to Essential which means the same but only works with this fix
Change-Id: Idea87bb828b1a358874b59ddafccf00c6ddaf417
Reviewed-on: http://codereview.qt-project.org/5592
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
- this is needed to bring autodepended components in the right install order
Change-Id: Ic4ad1d3b152125827e9f533b9fd16a71d447cb02
Reviewed-on: http://codereview.qt-project.org/5077
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@nokia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
"Update Info:" should be only visible in updater mode and
only if there is some text to display.
Change-Id: I81e7c0cc0a5532026f63d64ae8529f945884b328
Reviewed-on: http://codereview.qt-project.org/4558
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
Since we need the list anyway, we can move the is empty
check to the beginning of the function.
Change-Id: Iebe04b6f2904a02c807edaa7586af8a83c115c0a
Reviewed-on: http://codereview.qt.nokia.com/3414
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
It should be way faster to iterate over the known installed
packages list instead of all components to figure out if they
are installed.
Change-Id: I2fdb54c4063a3a886828129ad344c59216eb6509
Reviewed-on: http://codereview.qt.nokia.com/3173
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Niels Weber <niels.2.weber@nokia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@nokia.com>
Add a regular expression constant. Remove superfluous
check if the component is in the list, as in worst case
both methods need to iterate over the list to notice that
the component does not exist.
Review-By: Niels Weber
The proper fix for 308dc03e would have been to check if we
run in installer mode and only than check default components
initially. Not sure how a1a130b9 could state that the code
would work as expected, as proper testing would have revealed
that the "Next" button now was enabled always enabled in
package manager mode and always disabled in updater mode...
Fixes also the problem seen by Niels that in package manager
case components would have been scheduled for uninstall even
if we just selected a new component without removing an other.
Reviewed-By: Niels Weber
