Earlier we used QFileInfo::baseName but that doesn't work properly if
'.' are used in file names. So start using fileName instead.
Task-number: QTBUG-61262
Change-Id: I474b9656ef6d83dfbcdbc6ba6e40f95e75853c80
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Since some registry settings with regard to the environment variables can
have the type set to REG_EXPAND_SZ then we need to ensure that this is
respected. Otherwise it will be changed to REG_SZ due to a limitation with
QSettings.
Task-number: QTIFW-794
Change-Id: Icaede82b151496367e531050082d416e19e15b56
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Add colon (:) symbol as alternative separator beetwen
component name and version to use dash (-) symbol in
component name.
For names with dash (-) symbol use colon (:) symbol
as separator in dependencies between name and version,
even if you do not specify a version.
Requirement example: package-with-dash:>=1.2.3, stable:1.x,
demo:v1.0-rc1, backward-compatibility:.
Also add test 'tst_ComponentIdentifier' for check new feature.
Task-number: QTIFW-948
Change-Id: I6340c8001dec369ed8d33fcc4a92c7bce660aec1
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
readFile method returns string and not boolean. Fix it to documentation.
Change-Id: I8454b423a01e93c747087de662e6795a72db26bd
Reviewed-by: Karim Pinter <karim.pinter@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
In windows if admin rights are asked, you have two minutes to answer
to the query. After that installing is not possible as there is no way to
go back to admin query.
Adding a possibility to restart the admin right query when 'No' pressed
or two minutes timeframe has passed in Windows. Requires
DisableAuthorizationFallback set to true, otherwize user is asked to use
fallback '--startserver'.
Task-number: QTIFW-988
Change-Id: Ide33b588299c981cfe653e7f53e7316a768d87bb
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
This doesn't implement a resume for checksum files and
resource files; there's no pressing need for those.
Task-number: QTIFW-5
Change-Id: Id14a3d9b46f2e16a15f52ae536d060d505b2f4f0
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Enabling HighDPI looks crappy in Linux. In MacOS this flag is not
supported so enable it only in Windows host.
Change-Id: I15167e45371daab1176b0043802bdc8a6954d67d
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
Core does not need reset when selecting 'Restart'. If resetting,
settings dialog will lose some of its values etc. temporary
repositories set from command line.
Task-number: QTIFW-1017
Change-Id: Ifd67e373eaeccd85b985012b36b4314f59f0138f
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
This fixes the build if IFW is built with a dynamically linked Qt, and
does not otherwise affect use of static builds of Qt.
Task-number: QTIFW-993
Change-Id: I1e6807e522adde339263c697fa4a1353250a2e3f
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
This allows macOS to display a proper error message to the user if their
OS version is too old, as opposed to (probably) crashing and displaying
an error dialog with a stack trace.
Change-Id: I37570062d7358cc6304182182f095c9e51e16d06
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@qt.io>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Somehow a newline snuck into the wrong place, and ???? is recognized as
a trigraph, which produces a warning.
Change-Id: If948c544cba7ca880db4077bc3192332ce87ea52
Reviewed-by: Gabriel de Dietrich <gabriel.dedietrich@qt.io>
Binarycreator assumed that install type is offline if no repositories
was set although --online-only was set. However, repositories might
be set later, for example in producetkeycheck::init().
Change-Id: Idd6d0e3304974773baefe3773be7e2948704575c
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
If any of the repositories was not found or had unparsable
Updates.xml, install failed although there was other valid
repositories. Fixed so that warning is printed when such repositories
found but continue install if there are other valid repositories.
Change-Id: I04fe8d91382a3ea97ce22cd64159a6a7d825128d
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Most likely the first QTreeView field which contains the Component Name is
the most valuable. Make sure that the name has enough space in QTreeView
to show the whole component name. This change prevents user to resize the
Component Name field
Change-Id: I5f7dc7158d2d6f9f6ed1b900eb8d312cd88c03ec
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
This should fix x11 authorization livelock problems
causing the installer to freeze after password entry.
There might be unrelated issues causeing further freezes.
Further explanation:
If sudo does not terminate then closing stderr has no effect
in remoteserver.cpp and the loop in adminauthorization_x11.cpp
reading from pipedData will never terminate, causing the installer
to freeze.
It is important to close all references to stderr and terminate all
applications that do not close stderr themselves in the fork/exec
chain from adminauthorization_x11.cpp up to the remoteserver.
Remoteserver will close stderr in remoteserver.cpp.
Forking is done in main cause we can arrange it so that no threads
are running up to this point. If any thread were running we would
need to fork/exec in the child to be sure to restore a
semi-deterministic state.
Task-number: QTIFW-934
Change-Id: I87374d3ff195b42da0248c83aff020d373306d93
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Searching existing sha1sum node and keep/replace/add it if needed.
These changes correct the adding of two SHA1 nodes when the packages
are repackaged (option --repository via repogen and binarycreator)
Change-Id: Ide99946644fd73fadc63f23d34d7aec16b0399a2
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Maintenance tool is an essential update. Essential updates should be
installed before non-essential updates. This change forces essential
updates to be installed first. The behavior is same as when
updating with visible UI.
Task-number: QTIFW-976
Change-Id: I360145821c4e2d1f3384efca641208acb9338d5e
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Althogh 'Checkable' value is set to package, that can contain packages to
install. Enabling the install of components using 'Checkable' value.
Change-Id: I05d65fe2da65644872d46bdef3accd5e3f16ad31
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
this also obsoletes the file list in src.pro, so it is deleted.
Change-Id: Ic3f7499e710e35bd785c8041c6c53e937c21092e
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
this is the standard way to start a new translation.
Change-Id: Ie0235e41e39484af0b832a9b7488501bc883aaea
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
