QStringBuilder improves the speed of string concatenation a lot ...
Change-Id: I9dedf7c3335ebf4a9194e837f9eb8135fae11356
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
Remove superfluous file engine tests. Introduce auto test
for newly added client server classes. Fix some wrong
implementations serverside for settings array handling and
broken arguments in process wrapper. Replace all other parts
that with new implementations. Remove now unused classes.
Change-Id: I6f9e836993096a2c2c06b06f2b06d7aa4b287e56
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
- use two different script engine instances
- one which lives from the beginning -> the controlScriptEngine
- the other one which will be reset if there are some new repositories
loaded
- now the core has a pointer to the gui object, but it should only be
used by the script engine so a QObject type should be enough
- engines are deleted as QObject children from the PackageManagerCore
- registered downloaded archives are removed
Change-Id: I60a4a32fb2e409059839ec11b10c57357454f57a
Reviewed-by: Michal Klocek <michal.klocek@digia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
Set 'component' name value for minimalprogressoperation.
Wihout the value sortOperationsBasedOnComponentDependencies
puts the operation to execute as the last one.
This creates 'freeze' of uninstallation bar
Change-Id: I3b894b2c48ed5008d1d265084451da6fc4e3ef86
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
Task-number: QTIFW-302
During the update of KdTools we removed a bit to much code, so the
compressed/ uncompressed size was never passed to the component. Now
we keep and set it properly again. Force an update of the uncompressed
component size once we have calculated all checked components.
Change-Id: I12a796b543bbacdef4fbbdac10ff1103612c4c61
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
- set the component name to every operation which comes from
a component
Change-Id: I3e4a1ab2896f7b469fe6606c7e89127c3d6fbc43
Reviewed-by: Niels Weber <niels.weber@digia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
Don't, Can't, etc abbreviations are used in informal speech. This is
okay in code comments etc, but user output should use the correct,
non-abbreviated terms.
Change-Id: I53c0dfa91596c151bfa7ef7b65f57d5084ceccde
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
- MessageBoxHandler::currentBestSuitParent() is a QWizard in most cases
and then it tries to add QWidgets to it, but it allows only QWizardPage
- this results in a memory leak of the translatewatch objects inside the
loader, but needs to be fixed in the QUiLoader see QTBUG-31818
Change-Id: I67b0cc78c3843d4bbe70f015a63b5c26bb7f9e2c
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
Reviewed-by: Niels Weber <niels.weber@digia.com>
- isValidLicense(fileName) -> isValidLicenseTextFile(fileName)
- so we don't confuse user with hasValidKey
Change-Id: Ife2a88f244a75238dec5d70c280e6b4331a34a8a
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
- the order of initializing the updatercomponents list was different
then the packagemanagercomponents list
- now every updatercomponents are inside the list before the scripts
are called
Change-Id: I2cfa8edb48326071f6976aa9f772afc477088719
Reviewed-by: Iikka Eklund <iikka.eklund@digia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
- with this the outsourced product key check code can
enable, disable or even add repositories
Change-Id: I390251b7f3bfa29a6f39a9ac44aa55ec15f780a2
Reviewed-by: Iikka Eklund <iikka.eklund@digia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
- it uses one scriptengine for everything and adds the components
or/and the install-controller in javascript closure contexts
- added the gui object to the component script context
- removed tabController from controlscript context
Change-Id: I3bd6c5dcf470666c30add1b7d04a8fdd094f5f11
Reviewed-by: Iikka Eklund <iikka.eklund@digia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
Change-Id: Ifef70bf0ef12b90972186f64ff9b0ae602f14420
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@digia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
"Multiple exclamation marks," he went on, shaking his head,
"are a sure sign of a diseased mind."
Change-Id: If8e39435db5962cea0bc2e5fa372389198f5d14f
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
Move the regexp into its own compilation unit, so we get it only
once and use a accessor to fetch the value. I guess we should do
the same with the constants file, as all strings get compiled in
the file including it. At least Ossi wasn't satisfied currently.
Change-Id: Ic495a82f4b3cfe7810523b12cd3ef255eb15f149
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
This is more temporary solution to be able to use
the 1.3 for new Qt releases.
Change-Id: Ic28c75547da7d4d0c2efcca08cdbd76f4a0ad9f6
Reviewed-by: Karsten Heimrich <karsten.heimrich@digia.com>
Reviewed-by: Iikka Eklund <iikka.eklund@digia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
Call m_vars value function directly.
1; To prevent recursive calls in case of key "Default".
2; To avoid the extra function call to fetch values from m_vars in
case of other values set in the object.
Change-Id: I8f40b53704d1f314071d7060d0c92829310c262d
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
Reviewed-by: Niels Weber <niels.weber@digia.com>
The higher the value, the higher up in the list the component
is ordered. Currently we handled it the opposite, thus we had
to assign every component a value to get sorting work.
Change-Id: I6003cb95b69ba4160eb822565edf120dd0f0543f
Reviewed-by: Niels Weber <niels.weber@digia.com>
Reviewed-by: Iikka Eklund <iikka.eklund@digia.com>
Reviewed-by: Tim Jenssen <tim.jenssen@digia.com>
