QuasarApp/installer-framework
4
0
Fork 0
mirror of https://github.com/QuasarApp/installer-framework.git synced 2025-04-27 14:04:32 +00:00
Code Issues Projects Releases Wiki Activity

Fix installer executable creation in Linux

Browse Source 
If Linux has several partitions and tmp is pointing to a different
partition than where we are trying to create installer executable with
binarycreator, binarycreator fails with 'Invalid cross-device link'.
Fixed so that tmp is not used when creating an installer executable.

Change-Id: Ieee52ee1929f980345a7940dd381cc94dbf3d40e
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
This commit is contained in:
Katja Marttila 2019-11-13 14:23:41 +02:00
parent 9c2a507215
commit 7bac504eb6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/binarycreator/binarycreator.cpp
View File

@ -409,7 +409,8 @@ static int assemble(Input input, const QInstaller::Settings &settings, const QSt
} }
#endif #endif
QTemporaryFile out; QFile out(generateTemporaryFileName());
QString targetName = input.outputPath; QString targetName = input.outputPath;
#ifdef Q_OS_MACOS #ifdef Q_OS_MACOS
QDir resourcePath(QFileInfo(input.outputPath).dir()); QDir resourcePath(QFileInfo(input.outputPath).dir());
@ -470,7 +471,6 @@ static int assemble(Input input, const QInstaller::Settings &settings, const QSt
QFile::remove(tempFile); QFile::remove(tempFile);
return EXIT_FAILURE; return EXIT_FAILURE;
} }
out.setAutoRemove(false);
#ifndef Q_OS_WIN #ifndef Q_OS_WIN
chmod755(out.fileName()); chmod755(out.fileName());