From 535a54337e28185eb9abfd6af1f91c79e2603802 Mon Sep 17 00:00:00 2001
From: Katja Marttila <katja.marttila@qt.io>
Date: Tue, 2 May 2017 13:21:53 +0300
Subject: [PATCH] Fix unnecessary component calculate in silentUpdate

If there are no updates available, no need to calculate components to
install

Change-Id: I95068ef0e062f1745cbe10138407e658befb2c5b
Reviewed-by: Antti Kokko <antti.kokko@qt.io>
---
 src/libs/installer/packagemanagercore.cpp | 26 +++++++++++++----------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp
index edd2460a..72e2ec92 100644
--- a/src/libs/installer/packagemanagercore.cpp
+++ b/src/libs/installer/packagemanagercore.cpp
@@ -1805,17 +1805,21 @@ void PackageManagerCore::updateComponentsSilently()
     const QList<QInstaller::Component*> componentList = components(
         ComponentType::Root | ComponentType::Descendants);
 
-    foreach (Component *comp, componentList) {
-        comp->setCheckState(Qt::Checked);
-    }
-    QString htmlOutput;
-    bool componentsOk = calculateComponents(&htmlOutput);
-    if (componentsOk) {
-        if (runPackageUpdater())
-            qDebug() << "Components updated successfully.";
-    }
-    else {
-        qDebug() << htmlOutput;
+    if (componentList.count() ==  0) {
+        qDebug() << "No updates available.";
+    } else {
+        foreach (Component *comp, componentList) {
+            comp->setCheckState(Qt::Checked);
+        }
+        QString htmlOutput;
+        bool componentsOk = calculateComponents(&htmlOutput);
+        if (componentsOk) {
+            if (runPackageUpdater())
+                qDebug() << "Components updated successfully.";
+        }
+        else {
+            qDebug() << htmlOutput;
+        }
     }
 }