QuasarApp/QuasarAppCoin
4
0
Fork 0
mirror of https://github.com/QuasarApp/QuasarAppCoin.git synced 2025-05-08 07:29:37 +00:00
Code Issues Projects Releases Wiki Activity

[net] feeler connections can be made to outbound peers in same netgroup

Browse Source 
Fixes a bug where feelers could be stuck trying to resolve a collision in the
tried table that is to an address in the same netgroup as an existing outbound peer.

Thanks to Muoi Tran for the original bug report and detailed debug logs to track
this down.

Github-Pull: 
Rebased-From: 4991e3c813c9848d3b3957ea3ad433f02fca9e81
Tree-SHA512: 2752c9909d55ff63b9143168033d0d3952effba7f911181919eb62291edf822ec54fffbb20e35b5c5f8cb1092d75c496665da00139dbebe5ce402cbea3ad87c5
This commit is contained in:
Suhas Daftuar 2019-02-26 15:04:48 -05:00 committed by Wladimir J. van der Laan
parent 561b00a02b
commit 487f0c3dc9
No known key found for this signature in database
GPG Key ID: 1E4AED62986CD25D
1 changed files with 8 additions and 2 deletions

10
src/net.cpp

@ -1765,9 +1765,15 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect)
addr = addrman.Select(fFeeler);
}
// if we selected an invalid address, restart
if (!addr.IsValid() || setConnected.count(addr.GetGroup()) || IsLocal(addr))
// Require outbound connections to be to distinct network groups
if (!fFeeler && setConnected.count(addr.GetGroup())) {
break;
}
// if we selected an invalid address, restart
if (!addr.IsValid() || IsLocal(addr)) {
break;
}
// If we didn't find an appropriate destination after trying 100 addresses fetched from addrman,
// stop this loop, and let the outer loop run again (which sleeps, adds seed nodes, recalculates