QuasarApp/QuasarAppCoin
4
0
Fork 0
mirror of https://github.com/QuasarApp/QuasarAppCoin.git synced 2025-05-08 23:49:36 +00:00
Code Issues Projects Releases Wiki Activity

Take non-importing keys into account for spendability warning in descriptor import

Browse Source 
Github-Pull: 
Rebased-From: b5d39877242504160a7f2c24c60c07a845d7a064
This commit is contained in:
Pieter Wuille 2019-04-06 08:23:19 -07:00 committed by MeshCollider
parent 802dcd37d1
commit 235550d019
2 changed files with 5 additions and 1 deletions
src/wallet
rpcdump.cpp
test/functional
wallet_importmulti.py

3
src/wallet/rpcdump.cpp

@ -1193,6 +1193,9 @@ static UniValue ProcessImportDescriptor(ImportData& import_data, std::map<CKeyID
bool spendable = std::all_of(pubkey_map.begin(), pubkey_map.end(),
[&](const std::pair<CKeyID, CPubKey>& used_key) {
return privkey_map.count(used_key.first) > 0;
}) && std::all_of(import_data.key_origins.begin(), import_data.key_origins.end(),
[&](const std::pair<CKeyID, std::pair<CPubKey, KeyOriginInfo>>& entry) {
return privkey_map.count(entry.first) > 0;
});
if (!watch_only && !spendable) {
warnings.push_back("Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag.");

3
test/functional/wallet_importmulti.py

@ -630,7 +630,8 @@ class ImportMultiTest(BitcoinTestFramework):
self.log.info("Should import a 1-of-2 bare multisig from descriptor")
self.test_importmulti({"desc": descsum_create("multi(1," + key1.pubkey + "," + key2.pubkey + ")"),
"timestamp": "now"},
success=True)
success=True,
warnings=["Some private keys are missing, outputs will be considered watchonly. If this is intentional, specify the watchonly flag."])
self.log.info("Should not treat individual keys from the imported bare multisig as watchonly")
test_address(self.nodes[1],
key1.p2pkh_addr,