QuasarApp/LIEF
4
0
Fork 0
mirror of https://github.com/QuasarApp/LIEF.git synced 2025-05-09 18:29:34 +00:00
Code Issues Projects Releases Wiki Activity

Do not throw in public headers

Browse Source 
especially for checks that are typically asserts.
This commit is contained in:
serge-sans-paille 2018-06-15 15:57:31 +02:00
parent f2f09d9c6d
commit 00aad800ae
2 changed files with 8 additions and 18 deletions

9
include/LIEF/associative_iterators.hpp

@ -17,6 +17,7 @@
#define LIEF_ASSOCIATIVE_ITERATORS_H_
#include <iostream>
#include <cmath>
#include <cassert>
#include <iterator>
#include <functional>
#include <algorithm>
@ -191,9 +192,7 @@ class dict_iterator : public std::iterator<
//add_const_t<ref_t> operator[](size_t n) const {
// if (n >= this->size()) {
// throw integrity_error(std::to_string(n) + " is out of bound");
// }
// assert(n < this->size() && "integrity_error: out of bound")
// auto it = this->begin();
// std::advance(it, n);
// return const_cast<add_const_t<ref_t>>(*it);
@ -274,9 +273,7 @@ class dict_iterator : public std::iterator<
template<typename U = typename DT::value_type>
typename std::enable_if<std::is_pointer<U>::value, add_const_t<ref_t>>::type
operator*() const {
if (*this->it_ == nullptr) {
throw integrity_error("nullptr");
}
assert(*this->it_ && "integrity error: nupptr");
return const_cast<add_const_t<ref_t>>(**it_);
}

17
include/LIEF/iterators.hpp

@ -18,6 +18,7 @@
#include <iostream>
#include <cmath>
#include <cstddef>
#include <cassert>
#include <iterator>
#include <functional>
#include <algorithm>
@ -130,9 +131,7 @@ class ref_iterator : public std::iterator<
add_const_t<ref_t> operator[](size_t n) const {
if (n >= this->size()) {
throw integrity_error(std::to_string(n) + " is out of bound");
}
assert(n < this->size() && "integrity error: out of bound");
ref_iterator* no_const_this = const_cast<ref_iterator*>(this);
@ -223,9 +222,7 @@ class ref_iterator : public std::iterator<
template<typename U = typename DT::value_type>
typename std::enable_if<std::is_pointer<U>::value, add_const_t<ref_t>>::type
operator*() const {
if (*this->it_ == nullptr) {
throw integrity_error("nullptr");
}
assert(*this->it_ && "integrity error: nullptr");
return const_cast<add_const_t<ref_t>>(**it_);
}
@ -390,9 +387,7 @@ class filter_iterator : public std::iterator<
template<typename U = typename DT::value_type>
typename std::enable_if<std::is_pointer<U>::value, add_const_t<ref_t>>::type
operator*() const {
if (*this->it_ == nullptr) {
throw integrity_error("nullptr");
}
assert(*this->it_ && "integrity error: nullptr");
return const_cast<add_const_t<ref_t>>(**it_);
}
@ -409,9 +404,7 @@ class filter_iterator : public std::iterator<
}
add_const_t<ref_t> operator[](size_t n) const {
if (n >= this->size()) {
throw integrity_error(std::to_string(n) + " is out of bound");
}
assert(n < this->size() && "integrity error: out of bound");
auto it = this->begin();
std::advance(it, n);